Project

General

Profile

Actions

Bug #83227

closed

Imported XML data may be broken

Added by Alexander Opitz over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
Extension Manager
Start date:
2017-12-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

If you have the PHP Extension XML in use, the Extension Import is done by ExtensionXmlPushParser

This sets the xml_set_character_data_handler for reading the data between the tags, but this function can be called multiple times per tag. The yet existing implementation can lead to missing/incorrect data (maybe dependency string can't be unserialized, as it happens on my sytsem for bootstrap_package 8.0.0 at the moment).

Found this issue in 7 LTS maybe it is older.

From function documentation: http://php.net/xml_set_character_data_handler
"Character data handler is called for every piece of a text in the XML document. It can be called multiple times inside each fragment (e.g. for non-ASCII strings)."

Actions #1

Updated by Alexander Opitz over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54936

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54936

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54936

Actions #5

Updated by Alexander Opitz over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55057

Actions #7

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55058

Actions #8

Updated by Alexander Opitz over 6 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF