Project

General

Profile

Actions

Bug #83390

closed

ReflectionServiceTest fails due to ReflectionService being a singleton

Added by Andreas Kienast almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
Start date:
2017-12-19
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:
Remote Sprint

Description

On my system, running all unit tests is not possible. The following tests fail for no recognizable reason on first sight:

1) TYPO3\CMS\Extbase\Tests\Unit\Reflection\ReflectionServiceTest::getClassTagsValues
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    'see' => Array (...)
-    'link' => Array (...)
+    'firsttest' => Array (...)
+    'anothertest' => Array (...)
 )

typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php:54
vendor/phpunit/phpunit/phpunit:53

2) TYPO3\CMS\Extbase\Tests\Unit\Reflection\ReflectionServiceTest::getClassTagValues
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'test for reflection'
 )

typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php:71
vendor/phpunit/phpunit/phpunit:53

3) TYPO3\CMS\Extbase\Tests\Unit\Reflection\ReflectionServiceTest::testIsClassTaggedWith
Failed asserting that false is true.

typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php:197
vendor/phpunit/phpunit/phpunit:53

It can be nailed down to ReflectionService being a singleton class which is not cleared up properly again.

Actions #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55164

Actions #2

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55164

Actions #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55164

Actions #4

Updated by Andreas Fernandez almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF