Bug #83476
closedFew attributes are missing when concatenating JS files
100%
Description
When using the config.concatenateJs = 1
option, the ResourceCompressor is loosing tag attributes such as the async
attribute in the concatenateJsFiles
method.
A fix would be to add 'async' => $fileOptions['async']
after line 201, but I guess, it's too dirty for the core?!
Aside: Fresh installation with just tiny template:
config { concatenateJs = 1 } page = PAGE page.10 = TEXT page.10.value = HELLO WORLD! page.includeJSFooter { combined = path/to/file.css combined.async = 1 }
Updated by Rune Piper almost 7 years ago
When using the config.concatenateJs = 1
option, the ResourceCompressor is loosing tag attributes such as the async attribute in the concatenateJsFiles
method.
A fix would be to add 'async' => $fileOptions['async']
after line 201, but I guess, it's too dirty for the core?! What if one file should be loaded via async and another not?
Aside: Fresh installation with just tiny template:
config { concatenateJs = 1 } page = PAGE page.10 = TEXT page.10.value = HELLO WORLD! page.includeJSFooter { combined = path/to/file.js combined.async = 1 }
Updated by Stephan Bauer over 6 years ago
Maybe it would be possible to take care of async or defer.
This would be very flexible if only those file are concatenated with the same options
It would be great for Google Pagespeed
Updated by Gerrit Code Review over 6 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Gerrit Code Review over 6 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Gerrit Code Review over 6 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Gerrit Code Review over 6 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Gerrit Code Review over 6 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Gerrit Code Review over 6 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57130
Updated by Rune Piper over 6 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 09576ce717d62173cd49d44ac3611550fabb3314.
Updated by Susanne Moog over 4 years ago
- Related to Bug #86982: JS async not working added