Bug #83570: New warning in PHP7.2 spams the logs and decreases performance - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #83570

closed

New warning in PHP7.2 spams the logs and decreases performance

Added by Mattia D over 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

next-patchlevel

Start date:

2018-01-15

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.2

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

When Typo tries to get the name of an object it may cause a warning if the parameter given to get_class() is either not an object or null. The supplied patch fixes the issue. I've only observed this issue on PHP 7.2

The file in question is: ./vendor/typo3/cms/typo3/sysext/extbase/Classes/Service/ImageService.php

P.S.: Do I have to fork Typo and create a Pull Request or is this patch sufficient? I hope I didn't set any properties I am not allowed to set in the bug report.

Files

ImageService_php72_bug.diff (502 Bytes) ImageService_php72_bug.diff

fix for the bug

Mattia D, 2018-01-15 13:11

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55370

Actions

Copy link

Updated by Georg Ringer over 6 years ago

you can either do a PR via github or you can follow the contribution workflow which can be found at https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/ to push it directly to Gerrit.

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55370

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55370

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55370

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55370

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55375

Actions

Copy link

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55376

Actions

Copy link