Task #84015

Use PSR-7 request params in viewpage module

Added by Benjamin Franzke over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2018-02-22
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b
the viewpage module is a native PSR-7 controller, therefore
GeneralUtility _GP() and getIndpEnv() should no longer be used.

Associated revisions

Revision fd8621d3 (diff)
Added by Benjamin Franzke over 1 year ago

[TASK] Use PSR-7 request params in viewpage module

Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b
the viewpage module is a native PSR-7 controller, therefore
GeneralUtility _GP() and getIndpEnv() should no longer be used.

Restructure the code to use strict typing (to prevent type casting all
over the code), unify naming ($pageId and $languageId), and to prevent
calculating $targetUrl twice.

Releases: master
Resolves: #84015
Related: #83987
Change-Id: I4f2821824a6f811f4eebda7ebdaf09febab5eecc
Reviewed-on: https://review.typo3.org/55867
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55867

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55867

#3 Updated by Benjamin Franzke over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF