Project

General

Profile

Actions

Bug #84069

closed

ProcessedFile should load defined storage

Added by Frans Saris almost 6 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
File Abstraction Layer (FAL)
Target version:
Start date:
2018-02-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The storage is defined in the sys_file_processedfile record and that value should be used. Now the storage assigned to the original file default processing folder is used.

But if you adjust the processing folder in a live installation or have some custom processing code that's able to use different storages to save your processed file this breaks.

Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55927

Actions #2

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55927

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55935

Actions #4

Updated by Frans Saris almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Stefan Froemken 6 months ago

Example: You're working with EXT:dropbox and you have opened the first folders, and list the first files. In that case sys_file_processedfile will be filled with records where column "storage" is the same as of the original file itself. In that case UID 2. Working with this remote storage is slow, so you set processedfolder to 1:/_processed_/dropbox (LocalDriver). But working on that storage is still very slow. It costs me hours to find out, that all records of sys_file_processedfile with storage 2 (dropbox) have to be deleted and created from scratch. While re-creating these records the sys_file_processedfile records get storage 1 now. And yes, now, working on remote storage is a lot faster.

The storage was already correct set:
https://github.com/TYPO3/typo3/blob/v12.4.5/typo3/sysext/core/Classes/Resource/ProcessedFile.php#L127

But this patch overwrites the previously correct storage again with the storage from the sys_file_processedfile record.

I would prefer to overwrite the storage only, if $this->storage is null.

Stefan

Actions

Also available in: Atom PDF