Bug #84071

Exception Call to a member function getTreeList() on null

Added by Manuel Selbach almost 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-02-27
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If there is a DataProcessor used in a FLUIDTEMPLATE object which tries to resolve storagePids from the configuration with recursion set,
the following exception occurs:

Call to a member function getTreeList() on null

Error thrown in file
typo3/cms/typo3/sysext/extbase/Classes/Configuration/FrontendConfigurationManager.php in line 258.
30 TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager::getRecursiveStoragePids("-8", 3)

typo3/cms/typo3/sysext/extbase/Classes/Configuration/AbstractConfigurationManager.php:
00198:                 $frameworkConfiguration['persistence']['storagePid'] = $this->getRecursiveStoragePids(
00199:                     implode(',', $storagePids),
00200:                     (int)$frameworkConfiguration['persistence']['recursive']
00201:                 );
00202:             }

This is, because the running order has changed with this change https://github.com/TYPO3/TYPO3.CMS/commit/5c048a4c8017e4d50ab5f2343970a0fd33e4aaed in TYPO3\CMS\Frontend\ContentObject\FluidTemplateContentObject::render.

If you follow into TYPO3\CMS\Fluid\View\StandaloneView::construct (which was previously executed before the execution of dataProcessors were called) the method TYPO3\CMS\Extbase\Configuration\ConfigurationManager::setContentObject is called.

As this is not valid now, the method TYPO3\CMS\Extbase\Configuration\FrontendConfigurationManager::getRecursiveStoragePids tries to retrieve data from "null" which throws the mentioned exception.

Associated revisions

Revision 9d34db4e (diff)
Added by Benjamin Franzke almost 2 years ago

[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths"

This reverts commit 5c048a4c8017e4d50ab5f2343970a0fd33e4aaed
as introduced in https://review.typo3.org/54416

That workaround for a fluid bug had side effects when DataProviders
expected a ConfigurationManager instance to be available. That is
nothing officially supported but broke some (bad behaving) DataProviders.
As the fluid bug has been fixed in https://github.com/TYPO3/Fluid/pull/342
(contained in release 2.5.2) we can revert the workaround now.

The functional test that was introduced next to the bugfix is not reverted,
as do want to keep that obviously.

Resolves: #84071
Releases: master, 8.7
Change-Id: Ie6f5541f0f217fee7e85df954bb964a32fd27367
Reviewed-on: https://review.typo3.org/56035
Tested-by: TYPO3com <>
Reviewed-by: Manuel Selbach <>
Tested-by: Manuel Selbach <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 63293d61 (diff)
Added by Benjamin Franzke almost 2 years ago

[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths"

This reverts commit 5c048a4c8017e4d50ab5f2343970a0fd33e4aaed
as introduced in https://review.typo3.org/54416

That workaround for a fluid bug had side effects when DataProviders
expected a ConfigurationManager instance to be available. That is
nothing officially supported but broke some (bad behaving) DataProviders.
As the fluid bug has been fixed in https://github.com/TYPO3/Fluid/pull/342
(contained in release 2.5.2) we can revert the workaround now.

The functional test that was introduced next to the bugfix is not reverted,
as do want to keep that obviously.

Resolves: #84071
Releases: master, 8.7
Change-Id: Ie6f5541f0f217fee7e85df954bb964a32fd27367
Reviewed-on: https://review.typo3.org/56045
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55928

#2 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55928

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56035

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56045

#5 Updated by Benjamin Franzke almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF