Project

General

Profile

Actions

Task #84117

closed

Epic #83968: PSR-11 Initiative

Do not reinitialize CacheManager and PackageManager in clearAllCache

Added by Benjamin Franzke almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
Start date:
2018-03-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Those (re)initializations originate from https://review.typo3.org/19605
were reinitializeClassLoaderAndCachesAndPackageManagement()
was used to "Reinitialize the class loader during clear cache actions"
(according to phpdoc).

Then with the changes in https://review.typo3.org/29811
reinitializeClassLoaderAndCachesAndPackageManagement()
was dropped and splitted into unregisterClassLoader(),
flagCachingFrameworkForReinitialization().
initializeCachingFramework() and initializePackageManagement().
(just historical info, still all good)

Then http://review.typo3.org/39827 came and dropped unregisterClassLoader
but left the CacheManager and PackageManager reinitialization in place
superfluously. It's superfluous as the original usecase was to
reinitialize the class loader which is no longer required.

Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55988

Actions #2

Updated by Benjamin Franzke almost 6 years ago

  • Priority changed from Should have to Won't have this time

This is wrong. Bootstrap::loadTypo3LoadedExtAndExtLocalconf requires $GLOBALS['TYPO3_LOADED_EXT'] and therefore initializePackageManagement is required.

Can be closed.

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/55988

Actions #4

Updated by Benjamin Franzke almost 6 years ago

  • Priority changed from Won't have this time to Should have

This is wrong. Bootstrap::loadTypo3LoadedExtAndExtLocalconf requires $GLOBALS['TYPO3_LOADED_EXT'] and therefore initializePackageManagement is required.

Need to revert myself here. There is NO new PackageManager required as the FailsafePackageManager loads all active extensions defined in PackagesStates.php.
Therefore my proposed solution is still valid.

Actions #5

Updated by Benjamin Franzke almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions #7

Updated by Benjamin Franzke over 4 years ago

  • Parent task set to #83968
Actions

Also available in: Atom PDF