Project

General

Profile

Actions

Bug #84137

closed

DB compare must show DB errors if compare fails

Added by Georg Ringer over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2018-03-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If compare fails because of wrong SQL, it must also show the error and not just a warning that it failed - that is really not helpful ...

example part for ext_tables.sql

CREATE TABLE tx_fo (
    uid int(11) NOT NULL auto_increment,
    pid int(11) DEFAULT '0' NOT NULL,
    tstamp int(11) DEFAULT '0' NOT NULL,
    table_name varchar(255) NOT NULL DEFAULT '',
    record_id  int(11) DEFAULT '0' NOT NULL,,
    status tinyint(4) DEFAULT '0' NOT NULL,
    user int(11) DEFAULT '0' NOT NULL,

    PRIMARY KEY (uid),
    KEY parent (pid)
);

problem is the double comma at the end of line 6.


Files

dberror.jpg (79.3 KB) dberror.jpg Guido S., 2018-03-08 21:57
dberror-with-message-field.jpg (86 KB) dberror-with-message-field.jpg Guido S., 2018-03-08 22:04
Actions #1

Updated by Guido S. over 6 years ago

Do you mean it is sufficient only to output the error message? As a test, I simply extended the exception.

Actions #3

Updated by Gerrit Code Review over 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56096

Actions #4

Updated by Guido S. over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF