Task #84284

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Use ServerRequestInterface in ContentElement/ElementInformationController

Added by Christian Kuhn about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-03-15
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
medium
Sprint Focus:
On Location Sprint

Related issues

Related to TYPO3 Core - Bug #84342: Error in record info when displaying references Closed 2018-03-16

Associated revisions

Revision 42509bf9 (diff)
Added by Saskia Schreiber about 2 years ago

[TASK] Use ServerRequestInterface in ContentElement/ElementInformationController

This patch changes the ElementInformationController to consistently
use the ServerRequestInterface object instead of GeneralUtility
for the retrieval of POST/GETvars and server environment variables.

Also, to prepare for refactoring in v10,
all public properties and methods except mainAction() will throw
a deprecation notice if called.

Resolves: #84284
Releases: master
Change-Id: I5e9e22833aa0868319daef6d3744966f2f35fbb8
Reviewed-on: https://review.typo3.org/56172
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision f970098b (diff)
Added by Saskia Schreiber about 2 years ago

[BUGFIX] Error in record info when displaying references

This fixes the regression introduced in task #84284
(PSR-7 rewrite of ElementInformationController).

getRecordActions() expects the full request as third parameter,
not the requestUri parameter.

Resolves: #84342
Related: #84284
Releases: master
Change-Id: I8fe91098cadfeaf7c90edf202c2ad7e2aa039abe
Reviewed-on: https://review.typo3.org/56217
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Christian Kuhn about 2 years ago

  • Subject changed from ContentElement/ElementInformationController to Use ServerRequestInterface in ContentElement/ElementInformationController

#2 Updated by Saskia Schreiber about 2 years ago

  • Assignee set to Saskia Schreiber

#3 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#6 Updated by Gerrit Code Review about 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#7 Updated by Gerrit Code Review about 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#8 Updated by Gerrit Code Review about 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#9 Updated by Gerrit Code Review about 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56172

#10 Updated by Saskia Schreiber about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#11 Updated by Saskia Schreiber about 2 years ago

  • Related to Bug #84342: Error in record info when displaying references added

#12 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF