Bug #84449

Validation error arguments are not applied if no EXT:form validation error translation is available

Added by Ralf Zimmermann about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2018-03-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Associated revisions

Revision 70b8ffc0 (diff)
Added by Ralf Zimmermann about 2 years ago

[BUGFIX] Validation error arguments are not applied

If an extbase error object wants to be translated through EXT:form and
no translation is found, the original error message will be shown.
Possibly existing error message arguments must be applied by calling
the error objects __toString() method.

Resolves: #84449
Releases: master, 8.7
Change-Id: I3d1f92a7d9c9abcc239bdab17b42a2cbb9e98d94
Reviewed-on: https://review.typo3.org/56328
Reviewed-by: Björn Jacob <>
Tested-by: Björn Jacob <>
Reviewed-by: Kay Strobach <>
Tested-by: Kay Strobach <>
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>

Revision a9f1117d (diff)
Added by Ralf Zimmermann about 2 years ago

[BUGFIX] Validation error arguments are not applied

If an extbase error object wants to be translated through EXT:form and
no translation is found, the original error message will be shown.
Possibly existing error message arguments must be applied by calling
the error objects __toString() method.

Resolves: #84449
Releases: master, 8.7
Change-Id: I3d1f92a7d9c9abcc239bdab17b42a2cbb9e98d94
Reviewed-on: https://review.typo3.org/56328
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-on: https://review.typo3.org/56743

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56328

#2 Updated by Ralf Zimmermann about 2 years ago

Test it:

form definition:

type: Form
identifier: test
label: test
prototypeName: standard
renderables:
  -
    type: Page
    identifier: page-1
    label: Step
    renderables:
      -
        type: DatePicker
        identifier: datepicker-1
        label: 'Date picker'
        properties:
          dateFormat: Y-m-d
          enableDatePicker: false
          displayTimeSelector: false

Type x within the input and submit the form.
The error message is 'The date "%s" was not recognized (for format "%s").' but should be 'The date "x" was not recognized (for format "Y-m-d").'

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56328

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56328

#5 Updated by Ralf Zimmermann about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review about 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56743

#7 Updated by Ralf Zimmermann about 2 years ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF