Bug #84497

RsaEncryptionEncoder::getRsaPublicKey() must not be deprecated

Added by Mathias Brodala over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-03-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With #84407 the RsaEncryptionEncoder::getRsaPublicKey() method was deprecated since it is used in the now deprecated request handling of that class.

However that method has value for 3rd party code too since otherwise people need to copy these lines into their code.

The method should not be deprecated. In fact RsaPublicKeyGenerationController should probably use it too to avoid code duplication.


Related issues

Related to TYPO3 Core - Task #84407: Extract request processing from RsaEncryptionEncoder Closed 2018-03-17

Associated revisions

Revision 811d2810 (diff)
Added by Mathias Brodala over 1 year ago

[BUGFIX] Do not deprecate RsaEncryptionEncoder::getRsaPublicKey()

Also use this API in the RSA public key controller to avoid code
duplication.

Change-Id: Ief09eff9fb8f2370d545f93ec8187ae64b1c3f1a
Resolves: #84497
Releases: master
Reviewed-on: https://review.typo3.org/56378
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Mathias Brodala over 1 year ago

  • Related to Task #84407: Extract request processing from RsaEncryptionEncoder added

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56378

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56378

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56378

#5 Updated by Mathias Brodala over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF