Bug #84520

stdWrap.ifBlank introduced different behavior

Added by Oliver Hader over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
Start date:
2018-03-22
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

The patch for issue #84434 introduced a different behavior for the stdWrap.ifBlank feature.
The current implementation now ignores whitespace characters (tab, spaces, new lines, carriage return) which was not the case in previous TYPO3 versions - as a comparison:

  • TYPO3 v7: trim($content) === ''
  • TYPO3 v6.2: !strlen(trim($content))
  • TYPO3 v.4.5: !strlen(trim($content))
  • TYPO3 v4.3: !strlen(trim($content)

Associated revisions

Revision 18aaf1b5 (diff)
Added by Oliver Hader over 1 year ago

Revert "[BUGFIX] Test ifBlank with strlen again"

This reverts commit ac72c832b9d037c837a244b318984a6e1f4abd50.

The patch for issue #84434 introduced a different behavior for the
stdWrap.ifBlank feature. The current implementation now ignores
whitespace characters (tab, spaces, new lines, carriage return)
which was not the case in previous TYPO3 versions - as a comparison:

  • TYPO3 v7: trim($content) === ''
  • TYPO3 v6.2: !strlen(trim($content))
  • TYPO3 v.4.5: !strlen(trim($content))
  • TYPO3 v4.3: !strlen(trim($content)

Thus, the trim() part is basically missing currently. To avoid this
regression concerning the change of behavior, the change is reverted.

Related: #84434
Resolves: #84520
Releases: master, 8.7
Change-Id: I1fcbd0d249e18d06a96d481bf44a39de0662bed1
Reviewed-on: https://review.typo3.org/56421
Reviewed-by: Susanne Moog <>
Tested-by: TYPO3com <>
Reviewed-by: Jigal van Hemert <>
Reviewed-by: Frank Naegler <>
Tested-by: Susanne Moog <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 00ff3025 (diff)
Added by Oliver Hader over 1 year ago

Revert "[BUGFIX] Test ifBlank with strlen again"

This reverts commit c12fe3c17c3d339e9c84e8867ac9f6433e4953ca.

The patch for issue #84434 introduced a different behavior for the
stdWrap.ifBlank feature. The current implementation now ignores
whitespace characters (tab, spaces, new lines, carriage return)
which was not the case in previous TYPO3 versions - as a comparison:

  • TYPO3 v7: trim($content) === ''
  • TYPO3 v6.2: !strlen(trim($content))
  • TYPO3 v.4.5: !strlen(trim($content))
  • TYPO3 v4.3: !strlen(trim($content)

Thus, the trim() part is basically missing currently. To avoid this
regression concerning the change of behavior, the change is reverted.

Related: #84434
Resolves: #84520
Releases: master, 8.7
Change-Id: I1fcbd0d249e18d06a96d481bf44a39de0662bed1
Reviewed-on: https://review.typo3.org/56422
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56421

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56422

#3 Updated by Oliver Hader over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF