Bug #84530

Deprecate globals usage in FormEngine

Added by Nicole Cordes over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
FormEngine aka TCEforms
Target version:
Start date:
2018-03-24
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Instead of removing the handling of _GP(defVals), it needs to be deprecated in FormEngine. I think FormEngine is public API and there is no way to find out if the current version handles _GP(defVals) on its own or needs proper configuration from outside. If you set configuration from outside your code will throw an error if the new configuration is not supported (e.g. with 9.1).

As there is no method that can be used to determine if configuration is needed, I think the _GP usage needs to be deprecated "softly".


Related issues

Related to TYPO3 Core - Task #84506: Free FormEngine from _GP usage Closed 2018-03-21

Associated revisions

Revision 5814b35b (diff)
Added by Nicole Cordes over 1 year ago

[BUGFIX] Correctly deprecate globals usage in FormEngine

Resolves: #84530
Releases: master
Change-Id: Idb8fc143d7126840f0d964697b2a6dbe71e72cb3
Reviewed-on: https://review.typo3.org/56443
Tested-by: TYPO3com <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Tobi Kretschmann <>
Reviewed-by: Steffen Frese <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Alexander Opitz <>
Tested-by: Alexander Opitz <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56443

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56443

#3 Updated by Mathias Brodala over 1 year ago

  • Related to Task #84506: Free FormEngine from _GP usage added

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56443

#5 Updated by Nicole Cordes over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF