Project

General

Profile

Actions

Task #84658

closed

Do not change sorting when record gets deleted

Added by Tim Schreiner over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2018-04-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There seems no actual advantage of updating the field defined in sortby TCA ctrl section when a record gets deleted.
Updating the field leads to problems when restoring a whole page with recycler.

Steps to reproduce:

  1. Install recycler extension
  2. Create a new page
  3. Add two content elements to it
  4. Delete the whole page (the content elements get also deleted)
  5. Restore that page with sub-records using recycler

The result is, that the content elements both has sorting set to 1000000000. So the original sorting is completely lost. When removing a page with some more content elements, then the to re-arrangement can take some time.

Actions #1

Updated by Tim Schreiner over 6 years ago

I have created a patch for this. Unit and functional tests are all running, after changing the expected sorting.
Will now check acceptance and do some manual testing. When everything is fine, I will push the patch to review.

Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56609

Actions #3

Updated by Tim Schreiner over 6 years ago

  • Tracker changed from Feature to Task
  • TYPO3 Version set to 9
Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56609

Actions #5

Updated by Tim Schreiner over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF