Task #84658

Do not change sorting when record gets deleted

Added by Tim Schreiner over 1 year ago. Updated 11 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2018-04-07
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There seems no actual advantage of updating the field defined in sortby TCA ctrl section when a record gets deleted.
Updating the field leads to problems when restoring a whole page with recycler.

Steps to reproduce:

  1. Install recycler extension
  2. Create a new page
  3. Add two content elements to it
  4. Delete the whole page (the content elements get also deleted)
  5. Restore that page with sub-records using recycler

The result is, that the content elements both has sorting set to 1000000000. So the original sorting is completely lost. When removing a page with some more content elements, then the to re-arrangement can take some time.

Associated revisions

Revision 9bdbb366 (diff)
Added by Tim Schreiner over 1 year ago

[BUGFIX] Keep sorting column value for deleted records

Keep the value for the defined sorting field when a record is
deleted. This improves the quality of restored records especially
for tt_content records when a whole page is restored.

This change might be breaking for functional tests in third-party
extensions that rely on deleted records.

Resolves: #84658
Releases: master
Change-Id: I7714d73d07a8c78da56603230bde8ede6c02d8f4
Reviewed-on: https://review.typo3.org/56609
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Tested-by: Jan Stockfisch <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Tim Schreiner over 1 year ago

I have created a patch for this. Unit and functional tests are all running, after changing the expected sorting.
Will now check acceptance and do some manual testing. When everything is fine, I will push the patch to review.

#2 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56609

#3 Updated by Tim Schreiner over 1 year ago

  • Tracker changed from Feature to Task
  • TYPO3 Version set to 9

#4 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56609

#5 Updated by Tim Schreiner over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 11 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF