Project

General

Profile

Actions

Feature #84706

closed

Database analyser can't detect index length changes

Added by Kevin Ditscheid over 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2018-04-12
Due date:
% Done:

0%

Estimated time:
PHP Version:
7.1
Tags:
Complexity:
Sprint Focus:

Description

I stumbled accross this while updating a TYPO3 7.6 instance to 8.7, where the sys_refindex table got a few changes to the ref_string field. The index lookup_string got a change regarding its length.
This change is not recognized by the database analyser and thus the change of the fieldlength for ref_string to varchar(1000) will fail, if the database does not allow keys of such length.

It would be great if the database analyser could detect the change of indexes and could repair these.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81578: sys_refindex CHANGE ref_string: Index column size too largeClosed2017-06-14

Actions
Actions #1

Updated by Christian Kuhn almost 6 years ago

confirmed. stumbled upon that too, some time ago. i suspect doctrine on that, but did not dig deeper, yet. I'd say that is not super critical, but it would be cool if we could get that up and running again.

Actions #2

Updated by Henri Nathanson almost 6 years ago

Same here. Update 7.6 -> 8.7. Mysql 5.6.19.

https://github.com/drud/ddev/issues/654

So with another database server - Mittwald configured server with 5.6.33 - changing the column definition results in another key(index) definition. No prob here.

  KEY `lookup_string` (`ref_string`)
) ENGINE=MyISAM DEFAULT CHARSET=utf8

  KEY `lookup_string` (`ref_string`(333))
) ENGINE=MyISAM DEFAULT CHARSET=utf8

Mittwald
innodb_large_prefix = OFF
DOMAINFACTORY (error here)
innodb_large_prefix = ON

If I change the table definition to

  KEY `lookup_string` (`ref_string`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8 ROW_FORMAT=DYNAMIC;

it works fine with the database analyzer. But I am not doing a single table format change, or?

Actions #3

Updated by Henri Nathanson almost 6 years ago

  • Related to Bug #81578: sys_refindex CHANGE ref_string: Index column size too large added
Actions #4

Updated by Henri Nathanson almost 6 years ago

  • Related to Bug #81578: sys_refindex CHANGE ref_string: Index column size too large added
Actions #5

Updated by Henri Nathanson almost 6 years ago

  • Related to deleted (Bug #81578: sys_refindex CHANGE ref_string: Index column size too large)
Actions #6

Updated by Benni Mack over 4 years ago

  • Status changed from New to Closed

We've fixed this now in TYPO3 v9 and TYPO3 v10 with this change here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61476

Actions

Also available in: Atom PDF