Bug #84834

Epic #84751: Save Button Gate

Language selector not shown in page of default language without translation

Added by Patrick Broens about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Category:
Backend User Interface
Target version:
Start date:
2018-04-21
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:
On Location Sprint

Description

When editing a page, the language selector in the left upper corner is not visible when the page is in the default language and does not have a translation yet.

The language selector combines two functions: Switch to another language or translate the page. The editor should be able to translate the page when the page has been saved.

After_no_translations.png View (60.3 KB) Patrick Broens, 2018-04-21 11:58

After_1_of_many_translations.png View (52.9 KB) Patrick Broens, 2018-04-21 11:58

Before_1_of_many_translations.png View (54 KB) Patrick Broens, 2018-04-21 11:58

Before_no_translations.png View (40.4 KB) Patrick Broens, 2018-04-21 11:58

Associated revisions

Revision 57225f2c (diff)
Added by Patrick Broens almost 2 years ago

[BUGFIX] Language selector not shown in default page without translation

When editing a page, the language selector in the upper left corner is
not visible when the page is in the default language and does not have a
translation yet. When the page has at least one translation, the language
selector is visible, which is inconsistent behaviour.

This patch adds a check for the table. When the languages for the page
table are fetched, all languages are fetched.

Resolves: #84834
Releases: master
Change-Id: Ib482fecef6cbddcbf945e0e4d944e181c27a115c
Reviewed-on: https://review.typo3.org/56774
Reviewed-by: Sebastian Hofer <>
Tested-by: Sebastian Hofer <>
Tested-by: TYPO3com <>
Reviewed-by: Torben Hansen <>
Tested-by: Torben Hansen <>
Reviewed-by: Tobi Kretschmann <>
Tested-by: Tobi Kretschmann <>
Reviewed-by: Christian Hellmund <>
Reviewed-by: Florian Mast <>
Tested-by: Florian Mast <>
Reviewed-by: Ruslan Steiger <>
Tested-by: Ruslan Steiger <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56774

#3 Updated by Benni Mack almost 2 years ago

  • Target version changed from 9.3 to 9.4

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56774

#5 Updated by Patrick Broens almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF