Task #84836

Create a template with best practices for php files in Build/Scripts

Added by Sybille Peters about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Should have
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2018-04-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Some of the existing scripts in Build/Scripts have been converted to PHP. New scripts will be created. It might be good to have a template which includes some best practices, e.g.

  • security: abort script if not called from command line
  • handle command line arguments
  • Apply PSR-1 2.3 Side Effects ? Which could mean do not define class and execute it in one file.
  • ... more?

This script could continuously be refined and the other scripts updated at least for critical and security-related things.


Related issues

Related to TYPO3 Core - Task #83249: Use Composer scripts to simplify developmentClosedMathias Brodala2017-12-07

Actions
#1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#2

Updated by Gerrit Code Review about 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#3

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
#4

Updated by Sybille Peters about 3 years ago

  • Description updated (diff)
#5

Updated by Gerrit Code Review about 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#6

Updated by Gerrit Code Review about 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#7

Updated by Gerrit Code Review about 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#8

Updated by Gerrit Code Review about 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#9

Updated by Simon Gilli about 3 years ago

  • Related to Task #83249: Use Composer scripts to simplify development added
#10

Updated by Sybille Peters about 3 years ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF