Task #84836

Create a template with best practices for php files in Build/Scripts

Added by Sybille Peters over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Category:
System/Bootstrap/Configuration
Target version:
Start date:
2018-04-22
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Some of the existing scripts in Build/Scripts have been converted to PHP. New scripts will be created. It might be good to have a template which includes some best practices, e.g.

  • security: abort script if not called from command line
  • handle command line arguments
  • Apply PSR-1 2.3 Side Effects ? Which could mean do not define class and execute it in one file.
  • ... more?

This script could continuously be refined and the other scripts updated at least for critical and security-related things.


Related issues

Related to TYPO3 Core - Task #83249: Use Composer scripts to simplify development Closed 2017-12-07

Associated revisions

Revision cadbc4d2 (diff)
Added by Mathias Brodala over 1 year ago

[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

composer t:p:u

Also arbitrary arguments can be passed to the executed command:

composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54959
Tested-by: TYPO3com <>
Reviewed-by: Sybille Peters <>
Tested-by: Sybille Peters <>
Reviewed-by: Jigal van Hemert <>
Tested-by: Jigal van Hemert <>
Reviewed-by: Patricia Tiedemann <>
Tested-by: Patricia Tiedemann <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

Revision e04913ff (diff)
Added by Mathias Brodala over 1 year ago

[TASK] Add various Composer scripts

This vastly simplifies running common commands for TYPO3 development.

E.g. executing PHPUnit can be done like this:

composer test:php:unit

Since Composer uses Symfony Console this can even be shortened:

composer t:p:u

Also arbitrary arguments can be passed to the executed command:

composer t:p:u -- --filter unitTestMethodName

Change-Id: I3ef62417227b3c4c1c3d8f8f3662052ca36ed885
Resolves: #83249
Related: #84836
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57480
Tested-by: TYPO3com <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#3 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#4 Updated by Sybille Peters over 1 year ago

  • Description updated (diff)

#5 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#6 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#7 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#8 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/56780

#9 Updated by Simon Gilli over 1 year ago

  • Related to Task #83249: Use Composer scripts to simplify development added

#10 Updated by Sybille Peters over 1 year ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF