Task #85125

Deprecate usages of CharsetConverter in core

Added by Benni Mack over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
Start date:
2018-05-30
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #85139: Invalid arguments for method call matcher Closed 2018-06-01

Associated revisions

Revision 557a6df2 (diff)
Added by Benni Mack over 1 year ago

[TASK] Deprecate usages of CharsetConverter in core

CharsetConverter is still instantiated in some places and not needed at all times.

The following places have CharsetConverter completely removed (as internal property):
- PageRenderer
- SearchController
- Indexer

The AbstractHierarchicalFilesystemDriver's shorthand method getCharsetConversion()
has been deprecated, as drivers should instantiate the CharsetConversion themself.

Indexed Search's Lexer has a public property "csObj" which has been switched to
protected, where a deprecation message will be thrown.

Resolves: #85125
Releases: master
Change-Id: I48fd110ecd25bb6a4225a3d2141edc5fc3b92673
Reviewed-on: https://review.typo3.org/57097
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57097

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57097

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57097

#4 Updated by Benni Mack over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Mathias Brodala over 1 year ago

  • Related to Bug #85139: Invalid arguments for method call matcher added

#6 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF