Project

General

Profile

Actions

Bug #85229

closed

Invalid condition in suggest receiver page collection

Added by Alexander Stehlik almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2018-06-11
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

An invalid condition was introduced in getAllSubpagesOfPage() in the SuggestWizardDefaultReceiver in #77049:

$rows = array_column(($rows ?: []), 'uid', 'uid');
if (!count($rows)) {
    $pageIds = array_keys($rows);
    $pages = array_merge($pages, $pageIds);
} else {
    break;
}

The loop quits when there are no results!

Hint for testing

The error is only relevant when a custom recursive PID list is used:

TCEFORM.pages.content_from_pid.suggest.default {
    pidList = 12
    pidDepth = 99
}

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #77049: Doctrine: Migrate ext:backend/Form/Wizard/SuggestWizardDefaultReceiverClosedJacob Rasmussen2016-07-12

Actions
Actions #1

Updated by Alexander Stehlik almost 6 years ago

  • Related to Task #77049: Doctrine: Migrate ext:backend/Form/Wizard/SuggestWizardDefaultReceiver added
Actions #2

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57194

Actions #3

Updated by Alexander Stehlik almost 6 years ago

  • Description updated (diff)
Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57194

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57194

Actions #6

Updated by Gerrit Code Review almost 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57336

Actions #7

Updated by Alexander Stehlik almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF