Task #85258

Rename $sortRow variable in the datahandler

Added by Tymoteusz Motylewski over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-06-13
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Datahandler in many sorting related functions uses $sortRow variable which actually contains the column name defined in ['ctrl']['sortby'] TCA configuration.

To make the code easier to understand the variable should be renamed to sth like $sortColumn

Associated revisions

Revision 4428c601 (diff)
Added by Tymoteusz Motylewski over 1 year ago

[TASK] Rename $sortRow to $sortColumn in DataHandler

The new name makes the code easier to understand, as the variable
contains the column name configured in ['ctrl']['sortby'].

Resolves: #85258
Releases: master
Change-Id: I0237809c9029a634a50753a6978f74831ae8c14f
Reviewed-on: https://review.typo3.org/57214
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57214

#2 Updated by Tymoteusz Motylewski over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF