Project

General

Profile

Actions

Bug #85328

closed

linkvalidator still checks for tt_news in 8.7 + breaks with certain links

Added by schmitz no-lastname-given almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2018-06-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

mod.linkvalidator {
    searchFields {
        pages = media,url
        tt_content = bodytext,header_link,records
        tt_news = bodytext,links
    }
    linktypes = db,file,external
    checkhidden = 0
    showCheckLinkTab = 1
    mail {
        fromname = Linkvalidator
        fromemail = Linkvalidator@example.com
        replytoname =
        replytoemail =
        subject = TYPO3 Linkvalidator report
    }
    linkhandler.reportHiddenRecords = 0
}

searchFields for linkvalidator still includes tt_news which results in the following error, while using the linkvalidator check in TYPO3 8.7:

Argument 3 passed to TYPO3\CMS\Core\Database\Query\QueryBuilder::select() must be of the type string, null given, called in [...]/typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php on line 189

I think removing the line tt_news = bodytext,links would be OK, because tx_news is adding their own fields automatically.


Furthermore, when scanning links like http://www.chemmedchem.org/ I get this error:

Call to a member function getStatusCode() on null

Error thrown in file
[...]/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php in line 93.

16 TYPO3\CMS\Linkvalidator\Linktype\ExternalLinktype::checkLink("http://www.chemmedchem.org/", array, TYPO3\CMS\Linkvalidator\LinkAnalyzer)

Actions #1

Updated by schmitz no-lastname-given almost 6 years ago

  • Subject changed from linkvalidator still checks for tt_news in 8.7 to linkvalidator still checks for tt_news in 8.7 + breaks with certain links
  • Description updated (diff)
Actions #2

Updated by schmitz no-lastname-given almost 6 years ago

  • Description updated (diff)
Actions #3

Updated by Georg Ringer almost 6 years ago

what is strange that there is this check in LinkAnalyzer:

            // If table is not configured, assume the extension is not installed
            // and therefore no need to check it
            if (!is_array($GLOBALS['TCA'][$table])) {
                continue;
            }

so that should never happen

Actions #4

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57350

Actions #5

Updated by Georg Ringer almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57485

Actions #7

Updated by Georg Ringer over 5 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF