Project

General

Profile

Actions

Bug #85379

closed

linkvalidator breaks with certain links

Added by schmitz no-lastname-given almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Linkvalidator
Target version:
-
Start date:
2018-06-25
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When scanning links like http://www.chemmedchem.org/ in the content, I get this error when using the linkvalidator:

Call to a member function getStatusCode() on null

Error thrown in file
[...]/typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php in line 93.

16 TYPO3\CMS\Linkvalidator\Linktype\ExternalLinktype::checkLink("http://www.chemmedchem.org/", array, TYPO3\CMS\Linkvalidator\LinkAnalyzer)

Files

7-6.png (16 KB) 7-6.png Josef Glatz, 2018-06-25 15:21
Actions #1

Updated by Josef Glatz almost 6 years ago

Quick testing:

TYPO3 9.4.0-dev (master)

does not throw an error (the checked link isn't reported as broken.) I don't know if the page is reported as OK (There is no overview within linkvalidator about "good" links)

TYPO3 7.6 master

does report a broken link but doesn't "crash"

  • TYPO3 8.7.latest (stable)

crashes like described in the initial ticket description


Response Headers: there are multiple 301 redirects

> http http://www.chemmedchem.org/ -h

HTTP/1.1 301 Moved Permanently
Connection: Keep-Alive
Content-Length: 242
Content-Type: text/html; charset=iso-8859-1
Date: Mon, 25 Jun 2018 13:23:09 GMT
Keep-Alive: timeout=5, max=100
Location: http://www.wiley-vch.de/home/cmec/
Server: Apache

> http http://www.wiley-vch.de/home/cmec/ -h

HTTP/1.1 301 Moved Permanently
Connection: Keep-Alive
Content-Length: 287
Content-Type: text/html; charset=iso-8859-1
Date: Mon, 25 Jun 2018 13:24:00 GMT
Keep-Alive: timeout=5, max=100
Location: https://application.wiley-vch.de/admin/map.home-to-journal.php/journals/2452wis
Server: Apache

> http https://application.wiley-vch.de/admin/map.home-to-journal.php/journals/2452wis -h

HTTP/1.1 301 Moved Permanently
Connection: Keep-Alive
Content-Length: 0
Content-Type: text/html; charset=UTF-8
Date: Mon, 25 Jun 2018 13:24:24 GMT
Keep-Alive: timeout=5, max=100
Location: http://onlinelibrary.wiley.com/journal/10.1002/(ISSN)1860-7187
Server: Apache
Actions #2

Updated by Sybille Peters over 5 years ago

  • Status changed from New to Needs Feedback

I can't reproduce the exception with current TYPO3 8 branch (8.7.20-dev).

I used the link http://www.chemmedchem.org/ (as suggested above)

The link is not broken, it gets redirected.

The link is not marked as broken and no exception gets thrown.

The error sounds familiar, and I believe we fixed it. Please check, if you can still reproduce.

Actions #3

Updated by schmitz no-lastname-given over 5 years ago

Sybille Peters wrote:

I can't reproduce the exception with current TYPO3 8 branch (8.7.20-dev).

I used the link http://www.chemmedchem.org/ (as suggested above)

The link is not broken, it gets redirected.

The link is not marked as broken and no exception gets thrown.

The error sounds familiar, and I believe we fixed it. Please check, if you can still reproduce.

This was fixed with TYPO3 8.7.19!
Thank you!

Actions #4

Updated by Sybille Peters over 5 years ago

  • Status changed from Needs Feedback to Closed
Actions

Also available in: Atom PDF