Bug #85509

Use same line endings in test as in tested function

Added by Jigal van Hemert over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2018-07-08
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:

Description

In \TYPO3\CMS\Extbase\Tests\Unit\Mvc\Cli\CommandTest::testGetDescription() PHP_EOL line endings are used while in \TYPO3\CMS\Extbase\Mvc\Cli\Command::getDescription() LF line endings were used. In Windows these are not the same and thus the test fails.

#1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57501

#2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57501

#3

Updated by Jigal van Hemert over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#4

Updated by Jigal van Hemert over 2 years ago

  • TYPO3 Version changed from 7 to 9

Test isn't present in v8, so no backport.

#5

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF