Project

General

Profile

Actions

Task #85610

closed

Remove skipped extbase text for argument not being array

Added by Anja Leichsenring over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2018-07-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

typo3/sysext/extbase/Tests/Unit/Mvc/RequestTest.php::setArgumentThrowsExceptionIfTheGivenArgumentValueIsAnObject

is skipped since a long time.

Investigating why it would be advisable to deny the usage of objects in request arguments, I got this conclusions:

there are two places reading the incoming request arguments and using them.
- typo3/sysext/extbase/Classes/Mvc/Controller/AbstractController.php::mapRequestArgumentsToControllerArguments uses the argument to set it to the controller arguments and in this process, deals with incoming objects just fine.
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php::processRequest uses the arguments to write the userSettings in writeUC(). This function takes incoming values and serializes them to store them in DB, is therefore able to handle objects just fine.

-> there is no reason to deny the usage of objects in extbase requests, therefor the (formely skipped) test can be deleted.

Actions #1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57649

Actions #2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57649

Actions #3

Updated by Anja Leichsenring over 6 years ago

  • Subject changed from Remove unnecessary skipped extbase text to Remove skipped extbase text for argument not being array
Actions #4

Updated by Anonymous over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF