Bug #85659

Retrieve correct PackageManager in Install Tool

Added by Nicole Cordes over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-07-26
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Using \TYPO3\CMS\Core\Core\Bootstrap::getEarlyInstances to retrieve an instance of PackageManager is the wrong way to go. We need to use GeneralUtility::makeInstance instead.


Related issues

Related to TYPO3 Core - Bug #85634: Core does not recover if PackageStates.php is corrupted/removed Closed 2018-07-24

Associated revisions

Revision 10c537f4 (diff)
Added by Nicole Cordes over 1 year ago

[BUGFIX] Use correct packageManager initializing

As the PackageManager is a singleton class, you should call
GeneralUtility::makeInstance to retrieve the instance. The bootstrap
correctly initializes the first instance and registers it as singleton
already.

Resolves: #85659
Releases: master
Change-Id: I414a3fe4004044b0cdf6d2d8978f7e3463886018
Reviewed-on: https://review.typo3.org/57692
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57692

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57692

#3 Updated by Nicole Cordes over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Markus Klein over 1 year ago

  • Related to Bug #85634: Core does not recover if PackageStates.php is corrupted/removed added

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF