Bug #85774

userTSConfig options.saveDocNew.table = 0 does not work anymore

Added by Claus Harup about 1 year ago. Updated 5 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Start date:
2018-08-07
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Running on TYPO3 v. 8.7.18

\TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addUserTSConfig('options.saveDocNew.tt_content = 0');

in ext_localconf.php does not hide the button no more :-(

I rolled back to TYPO3 v. 8.7.13 and then it worked again :-|

Hint: sysext/backend/Classes/Controller/EditDocumentController.php

Associated revisions

Revision e98c2496 (diff)
Added by Susanne Moog 11 months ago

[BUGFIX] Respect saveDocNew TSConfig option

For translated tt_content elements the saveDocNew button
was solely dependent on the free vs. connected mode setup.
However, if the button has been hidden via TSConfig
completely it should not magically reappear when editing a
translation in free mode.

(This patch only applies to TYPO3 8 as the buttons
changed for version 9).

Change-Id: I0f74e87acbac127b8bbc09f4fee39c633a3a49f6
Resolves: #85774
Releases: 8.7
Reviewed-on: https://review.typo3.org/58603
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Joerg Kummer <>
Tested-by: Joerg Kummer <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Guido Schmechel about 1 year ago

Related Bugfix: https://review.typo3.org/c/56817/

Following code (line 1230) ignores the settings

            // Hide the button for tt_content when in connected translation mode
            if ($this->firstEl['table'] === 'tt_content') {
                $showSaveAndNewButton = $this->isPageInFreeTranslationMode(
                    (int)$this->pageinfo['uid'],
                    !$isSavedRecord ? (int)$this->defVals['colPos'] : (int)$record['colPos'],
                    $sysLanguageUid
                );
            }

Maybe it should only check if sysLanguageUid is greater than 0?

#2 Updated by Claus Harup about 1 year ago

The sys_language_uid is 0... - and I agree, the check should only be done with value greater than 0 :-)

#3 Updated by Susanne Moog about 1 year ago

  • Target version changed from 8.7.19 to Candidate for patchlevel

#4 Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58602

#5 Updated by Gerrit Code Review 12 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58603

#6 Updated by Anonymous 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF