Task #85812

Epic #84726: Initiative: URL Routing Integration / Site Handling

Epic #84727: Site Handling - Part 2 / Missing Pieces

Task #85166: Add tests for a frontend rendering based on sites

Throw PSR-7 Responses up to Application

Added by Oliver Hader over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2018-08-10
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

In order to properly handle PSR-7 response objects explicit die() or exit() calls should be avoided since those states cannot be handled nor analyzed further. As a current work-around a new ImmediateResponseException is introduced that throws the exception up to application object that transforms the emitted message into a proper response object. This API is internal and considered as intermediate - the real solution would be to completely refactor TypoScriptFrontendController processing and only use request/response consequently.

Associated revisions

Revision a959a3f8 (diff)
Added by Oliver Hader over 1 year ago

[TASK] Throw PSR-7 Responses up to Application

In order to properly handle PSR-7 response objects explicit die()
or exit() calls should be avoided since those states cannot be
handle nor analyzed further. As a current work-around a new
ImmediateResponseException is introduced that throws the exception
up to application object that transforms the emitted message into
a proper response object. This API is internal and considered as
intermediate - the real solution would be to completely refactor
TypoScriptFrontendController processing and only use
request/response consequently.

Resolves: #85812
Releases: master
Change-Id: I047ad82fd5734c38160b8552aa754b1e7c356417
Reviewed-on: https://review.typo3.org/57866
Tested-by: TYPO3com <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 1 year ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57866

#2 Updated by Gerrit Code Review over 1 year ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57866

#3 Updated by Gerrit Code Review over 1 year ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57866

#4 Updated by Oliver Hader over 1 year ago

  • Parent task set to #85166

#5 Updated by Oliver Hader over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF