Bug #85912

Button "Paste after this record" or "Paste into this column" is broken

Added by Manuel Selbach 7 months ago. Updated 6 months ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
Start date:
2018-08-20
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a content element get's copied and tried to insert directly via the buttons defined in the subject, nothing happens.

How to reproduce:

- Open a page in the page module with some content on it
- Copy a content element
- try to paste it via the button "Paste after this record" or "Paste into this column"

Result:
- Nothing happens

This issue seems to be located in the DragDrop.js or in Paste.js


Subtasks

Bug #85911: Not working "Paste after this record" buttonClosedManuel Selbach

Associated revisions

Revision af788148 (diff)
Added by Andreas Fernandez 7 months ago

[BUGFIX] Decouple pasting from drag & drop handling

The "Paste" action now does not depend on the `DragDrop` anymore.
Previously, the `onDrop` event callback was called manually which is
wrong in that case, as the callback does far more calculations than
necessary when doing a simple paste action.

In the same run, the DragDrop module has been simplified, the module now
doesn't know anything about pasting content elements anymore.

Resolves: #85912
Releases: master
Change-Id: I3a8943e90a92c0ad4afec9e87091f9cd1878c34c
Reviewed-on: https://review.typo3.org/57970
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Reviewed-by: Manuel Selbach <>
Tested-by: Manuel Selbach <>
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>

History

#1 Updated by Andreas Fernandez 7 months ago

  • Status changed from New to In Progress

#2 Updated by Gerrit Code Review 7 months ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57970

#3 Updated by Gerrit Code Review 7 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/57970

#4 Updated by Andreas Fernandez 7 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 6 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF