TYPO3 Core

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58043

I don't get your example action? Why do you pass this error stuff in there?

Error stuff is here because we don't need validation at the start of action. We validate object only in some case. In some other we save not valid object.

As example for better understanding i will show you this simple story:

• User want to create new invoice address (address is another object with 30 fields)
• We allow him to create it with 4 steps, 3 steps per 10 fields and on last, he get confirmation
• OK, User enter on the step 1, he fill 3 fields after this he see field which is strange for him but this fields is required, so in this case he want to save his work. We allow him with special button.
• after some time User return to edit his Address
• he fill all required fields and click proceed button. Crap, he forget about one required field, he is very angry for this field and he closed browser. After some minutes he return to form and he see, his form is saved! With proceed action we always save object and after save we validate it to check if he can go to another step.

Ok, i finish this simple story in this moment, because now, you should know why we want to use

TYPO3\CMS\Extbase\Error\Result

Maybe fix solution for this problem is not correct but this should be fixed. The problem is in

typo3/cms/typo3/sysext/extbase/Classes/Reflection/ReflectionService.php::getPropertyTagsValues

ReflectionService::getPropertyTagsValues should return class Property tag valuse but in case of Error return empty array (see screenshot why empty array is returned)

Maybe fix should be for reflection service? Because error is thrown by:

$classPropertyTagsValues = $this->reflectionService->getPropertyTagsValues($targetClassName, $classPropertyName);
if (!isset($classPropertyTagsValues['var'])) {
   throw new \InvalidArgumentException(sprintf('There is no @var annotation for property "%s" in class "%s".', $classPropertyName, $targetClassName), 1363778104);
}

typo3/cms/typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php::276