Bug #85965

FileWriter fails to check for valid log file path

Added by Sebastian Michaelsen 11 months ago. Updated 11 months ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-08-24
Due date:
% Done:

0%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Core\Log\Writer\FileWriter::setLogFile() uses GeneralUtility::getFileAbsFileName() to get the absolute path to a given $logFile. GeneralUtility::getFileAbsFileName() always returns a string, even in an error case it returns an empty string. However the return value is checked for being null.

https://github.com/TYPO3/TYPO3.CMS/commit/bfdc332650a92839e8ae73ec21b29f23609b5a1e#r30280568

That means that exception #1444374805 can never be thrown.

This applies to v7, v8 and master.

History

#1 Updated by Wouter Wolters 11 months ago

  • Status changed from New to Rejected

Thanks for the report, has been solved meanwhile with https://forge.typo3.org/issues/85973

Also available in: Atom PDF