Project

General

Profile

Actions

Bug #85979

closed

PaginateViewHelper allows incompatible types for objects argument

Added by Daniel Goerz almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2018-08-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
no-brainer
Is Regression:
Yes
Sprint Focus:

Description

Was accidentally introduced by https://review.typo3.org/#/c/52784/

My question from the review:

Why did we allow $objects to be of type ObjectStorage or Array with this patch? The PaginateController calls ->getQuery() on $objects which neither of those two has.

Note the patch that introduced this bug was not backported to 8 yet.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #81200: Several ViewHelpers do not natively support compilingClosed2017-05-11

Actions
Actions #1

Updated by Daniel Goerz almost 6 years ago

  • Related to Bug #81200: Several ViewHelpers do not natively support compiling added
Actions #2

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58038

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58038

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58038

Actions #5

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58038

Actions #6

Updated by Anonymous almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Benni Mack almost 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF