Task #86083

Cleanup parameter mismatches

Added by Wouter Wolters 9 months ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2018-09-02
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Cleanup parameter mismatches.

Remove parameters that are used and are more than the declaration


Related issues

Related to TYPO3 Core - Bug #86252: Domain object doesn't get persisted correct Closed 2018-09-14

Associated revisions

Revision 266b4950 (diff)
Added by Wouter Wolters 9 months ago

[TASK] Cleanup parameter mismatches

Cleanup function calls that use more parameters than their declaration.

Resolves: #86083
Releases: master
Change-Id: Ic662cf71db4262141fe8754346ff45654d26091d
Reviewed-on: https://review.typo3.org/58123
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision c7b9b83d (diff)
Added by Daniel Lorenz 8 months ago

[BUGFIX] add propertyName to _isDirty() check

_isDirty() without the propertyName returns false if
propertyValue is an instance of DomainObjectInterface.

Resolves: #86252
Related: #86083
Releases: master
Change-Id: I3b916f6b3a416de6cd120bd1ff0bf5cfd0926445
Reviewed-on: https://review.typo3.org/58345
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 9 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58123

#2 Updated by Wouter Wolters 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Daniel Lorenz 8 months ago

  • Related to Bug #86252: Domain object doesn't get persisted correct added

#4 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF