Bug #86166

API of UpgradeWizardsService is inconsistent and exposes implementation details

Added by Helmut Hummel over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-09-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

That marking wizards done and undone happens implementation wise by using the registry,
shouldn't be reflected in public API.

In fact, we changed the implementation a while ago from conf vars to registry. Such change might happen again.

Also we have the API methods:

isWizardDone
markWizardAsDone

but also

markWizardUndoneInRegistry

or

getUpgradeWizardsList

but also

listOfWizardsDoneInRegistry
listOfRowUpdatersDoneInRegistry

#1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58199

#2

Updated by Helmut Hummel over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF