Task #86182

Epic #84272: Use PSR-7 ServerRequestInterface in backend controllers

Protect methods in TaskModuleController

Added by Christian Kuhn 10 months ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-09-07
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #86204: TaskModuleController does not extend BaseScriptClass anymore Closed 2018-09-09

Associated revisions

Revision 3b0a6428 (diff)
Added by Christian Kuhn 10 months ago

[TASK] Protect methods in TaskModuleController

Resolves: #86182
Releases: master
Change-Id: I80b8b519ad530d5d98e284e0666cd6c2eb3f5603
Reviewed-on: https://review.typo3.org/58212
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: rolandgolla <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>

Revision 98fcd3ee (diff)
Added by Christian Kuhn 10 months ago

[TASK] Protect TaskModuleController Part 2

TaskModuleController no longer extends BaseScriptClass. Properties
and methods are copied over to the controller and most of them are
set to protected. An instance of the controller class is given
to single class that fetch and set the one or the other information,
so not everything can be made protected. The patch should still
allow us to have more refactoring freedom in v10 in this area.

Resolves: #86204
Related: #86182
Releases: master
Change-Id: I171b22ddbcee67205234b6ca23acf9c95da6ac1b
Reviewed-on: https://review.typo3.org/58239
Tested-by: TYPO3com <>
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Frank Naegler <>
Tested-by: Frank Naegler <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58212

#2 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58214

#3 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58212

#4 Updated by Christian Kuhn 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Christian Kuhn 10 months ago

  • Related to Task #86204: TaskModuleController does not extend BaseScriptClass anymore added

#6 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF