Project

General

Profile

Actions

Bug #86257

closed

Invalid TypoScript condition expressions breaks TYPO3

Added by Frank Nägler almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
TypoScript
Target version:
Start date:
2018-09-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The symfony expression language has no type check, which results in PHP Warnings in case the in expression is used without an array.
example:

[1 in "foo"] will throw a PHP Warning: in_array() expects parameter 2 to be array

This case should be handled by the core in two different ways:

1) In Frontend a InvalidTypoScriptConditionException should be thrown (if strictSyntax feature toggle is enabled)
2) In Frontend silent catch this error and log it (if strictSyntax feature toggle is disabled)
3) In Backend silent catch this error and log it, but never break the backend.

Actions #1

Updated by Gerrit Code Review almost 6 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58280

Actions #2

Updated by Gerrit Code Review almost 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58280

Actions #3

Updated by Gerrit Code Review almost 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58280

Actions #4

Updated by Gerrit Code Review almost 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58280

Actions #5

Updated by Frank Nägler almost 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF