Bug #86294

Gallery Data-Processor of EXT:frontend casts the cropVariant into integer

Added by Thomas Deuling about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Frontend
Start date:
2018-09-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The Gallery Data-Processor of EXT:frontend casts the cropVariant into integer.
That isn't the expected behaviour, because cropVariant identifier also can be a string identifier like 'desktop' or 'mobile'.
This casting results, that always the default cropVariant is used, no matter if there is another one passed or not.

$this->cropVariant = (int)$this->getConfigurationValue('cropVariant') ?: 'default';
#1

Updated by Gerrit Code Review about 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58312

#2

Updated by Gerrit Code Review about 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58312

#3

Updated by Gerrit Code Review about 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58317

#4

Updated by Anonymous about 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack about 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF