Task #86564

Add return type declaration to FileDumpController::dumpAction

Added by Benjamin Franzke over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2018-10-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

For historical reasons FileDumpController::dumpAction was allowed to return
null. It didn't specify a nullable return type declaration because it was
unclear whether v9 will require php 7.2 or not.
With https://review.typo3.org/55585 FileDumpController was reworked to
always return a PSR-7 Response but missed to update the function signature.
That should be adapted.

#1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58574

#2

Updated by Benjamin Franzke over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#3

Updated by Benni Mack almost 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF