Bug #86743

Inline "then"/"else" not working for IfHasRoleViewHelper

Added by Mathias Brodala 10 months ago. Updated 4 months ago.

Status:
Closed
Priority:
Must have
Category:
Fluid
Target version:
Start date:
2018-10-25
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Since TYPO3v8 using the inline then and else arguments on the IfHasRoleViewHelper does not work anymore.

Thus {f:security.ifHasRole(role: 10, then: 'YES', else: 'NO')} leads to an error:

Undeclared arguments passed to ViewHelper TYPO3\CMS\Fluid\ViewHelpers\Security\IfHasRoleViewHelper: then, else. Valid arguments are: role

This happens because IfHasRoleViewHelper::initializeArguments() does not call the same method of TYPO3Fluid\Fluid\Core\ViewHelper\AbstractConditionViewHelper.

In TYPO3v7 this was avoided because TYPO3\CMS\Fluid\Core\ViewHelper\AbstractConditionViewHelper did register these arguments in its constructor. Thus this is a regression.

Associated revisions

Revision 28f0f0b2 (diff)
Added by Mathias Brodala 10 months ago

[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58692
Reviewed-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Reviewed-by: Daniel Goerz <>
Tested-by: Daniel Goerz <>
Reviewed-by: Joerg Kummer <>
Tested-by: Joerg Kummer <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

Revision c8840e8b (diff)
Added by Mathias Brodala 10 months ago

[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58702
Tested-by: TYPO3com <>
Reviewed-by: Joerg Kummer <>
Tested-by: Joerg Kummer <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>

History

#1 Updated by Gerrit Code Review 10 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58692

#2 Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58702

#3 Updated by Mathias Brodala 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Vasyl Mosiychuk 10 months ago

  • Related to Bug #86841: Inline "then"/"else" not working for <f:security.ifAuthenticated> added

#5 Updated by Mathias Brodala 10 months ago

  • Related to deleted (Bug #86841: Inline "then"/"else" not working for <f:security.ifAuthenticated>)

#6 Updated by Benni Mack 4 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF