Bug #86938

Implicit type cast through ArrayUtility::stripTagsFromValuesRecursive

Added by Wolfgang Klinger over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Must have
Category:
-
Target version:
-
Start date:
2018-11-15
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

`\TYPO3\CMS\Core\Utility\ArrayUtility::stripTagsFromValuesRecursive` does not care if the value is a number, so any integers are returned as strings.

That's a problem e.g. in the form extension, which uses this method in `\TYPO3\CMS\Form\Controller\FormEditorController::transformFormDefinitionForFormEditor`.
Because of this implicit type cast the strict comparison for default value keys in Javascript fails (even though the yaml file has the correct keys, aka integers set).

The method should only change strings.

#1

Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#2

Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#3

Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#4

Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#5

Updated by Gerrit Code Review over 2 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#6

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#7

Updated by Gerrit Code Review over 2 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58900

#8

Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/58914

#9

Updated by Wolfgang Klinger over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#10

Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF