Project

General

Profile

Actions
Copy link

Task #87051

closed

Little FIX for ArrayUtility.php

Added by Forger Service over 5 years ago. Updated over 5 years ago.

Status:
Rejected
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-11-30
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

Hi, i think its better to use '==' instead of '===', in this case will also match "",[],0... So i think its bettre option to remove empty stuff from array. What you think?

This issue was automatically created from https://github.com/TYPO3/TYPO3.CMS/pull/149

Actions
Copy link
 #1

Updated by Gerrit Code Review over 5 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59001

Actions
Copy link
 #2

Updated by Mathias Brodala over 5 years ago

  • Status changed from Under Review to Rejected

The strict type comparison is done on purpose here since the method is supposed to drop only NULL values, nothing else. A lot of places will break if we suddenly change this behavior.

For this reason we cannot do any change here.

Actions
Copy link

Also available in: Atom PDF