Project

General

Profile

Actions

Bug #87114

closed

frameborder attribute of iFrames is not removed when using doctype html5

Added by Till Schweneker almost 6 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2018-12-10
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

When using the following configuration and adding a YouTube or Vimeo video via the built in media embed, the iFrame is still having the frameborder attribute. The source code of the renderer however implies, that it would be removed.

config {
  doctype = html5
} 

Source code of /typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php #192

        if (is_object($GLOBALS['TSFE']) && $GLOBALS['TSFE']->config['config']['doctype'] !== 'html5') {
            $attributes[] = 'frameborder="0"';
        }

This behavior is present in TYPO3 9.5.1 and 8.7.20

Actions #1

Updated by Georg Ringer almost 6 years ago

I tested it on master only and can reproduce if the doctype is not set. 8 won't get the change anymore as it is on priority bugfix only

Actions #2

Updated by Georg Ringer almost 6 years ago

  • Status changed from New to Under Review
Actions #3

Updated by Georg Ringer over 4 years ago

  • Status changed from Under Review to Resolved

resolved with mentioned patch, therefore closed

Actions #4

Updated by Benni Mack over 4 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF