Bug #87182

ActionMenuItemViewHelper issue with selected-attribute

Added by Kevin Ditscheid almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2018-12-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The ActionMenuItemViewHelper is not resetting the selected-attribute for the rendered items, thus all options that follow a selected menu item, will also get selected.
It also does not respect the given arguments of the menu item. It also selects menu items with the same controller => action combination, but with different arguments.


Files

actionmenutest_0.0.2_201902241227.zip (6.08 KB) actionmenutest_0.0.2_201902241227.zip Stefanos Karasavvidis, 2019-02-24 11:28
actionmenutest_0.0.3_201902241238.zip (6.07 KB) actionmenutest_0.0.3_201902241238.zip Stefanos Karasavvidis, 2019-02-24 11:39
#1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#2

Updated by Gerrit Code Review almost 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#3

Updated by Gerrit Code Review almost 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#4

Updated by Gerrit Code Review almost 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#5

Updated by Gerrit Code Review almost 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#6

Updated by Gerrit Code Review over 2 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59176

#7

Updated by Stefanos Karasavvidis over 2 years ago

to reproduce this, you can use the attached extension. It has a simple backend module (under admin tools) that uses the ActionMenuItemViewHelper for 4 different actions:
index
list1
list2 with argument 1
list2 with argument 2

Using actions index and list1 leaves the dropdown correctly selected to the action that was used.

Using action list2 leaves the dropdown always to the last action in the list. The markup that is generated has the "selected" attribute in both options.

#9

Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59176

#10

Updated by Gerrit Code Review over 1 year ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63582

#11

Updated by Gerrit Code Review over 1 year ago

Patch set 2 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63582

#12

Updated by Kevin Ditscheid over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#13

Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF