Task #87245

Epic #87193: Remove deprecated code from the core

Drop support for deprecated CacheManager cache creation during ext_localconf.php loading

Added by Benjamin Franzke 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Start date:
2018-12-20
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #86353: Deprecate CacheManager usage in ext_localconf.php Closed 2018-09-21

Associated revisions

Revision 91dfd3d4 (diff)
Added by Benjamin Franzke 5 months ago

[!!!][TASK] Drop support for deprecated cache usage in ext_localconf

The initialization of the CacheManager has a design problem:

The CacheManager is used to create the core_cache. That core_cache
is used to read the (possibly) cached CacheManager configuration
(from ext_localconf.php), which is then used to (re)configure the
already-being-used CacheManager after ext_localconf.php has been
loaded. That means an extension can create a cache while it has
not been configured by a second extension. That behaviour was
deprecated in v9 and can therefore be dropped now.

We now create the core cache (and because of requirements
in core currently also the 'assets' cache) during early bootstrap
(independently from the CacheManager) and inject these early caches
into the CacheManager instance later on. The CacheManager instance is now
created during late bootstrap.
Looking forward to a Dependency Injection (DI) container, this change will
allow to move the CacheManager creation from bootstrap code into the DI
service providers (which will allow the CacheManager to be instantiated
on demand)

Releases: master
Resolves: #87245
Related: #86353
Change-Id: I984beabdbbd550c191de347fdc19166283452a88
Reviewed-on: https://review.typo3.org/59231
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Benjamin Franzke 6 months ago

  • Related to Task #86353: Deprecate CacheManager usage in ext_localconf.php added

#2 Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#3 Updated by Gerrit Code Review 6 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#4 Updated by Gerrit Code Review 6 months ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#5 Updated by Gerrit Code Review 5 months ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#6 Updated by Gerrit Code Review 5 months ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#7 Updated by Gerrit Code Review 5 months ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59231

#8 Updated by Benjamin Franzke 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF