Bug #87347

no_cache still present in core

Added by Claus Harup 6 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Start date:
2019-01-07
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Edit any page doktype = 0 and hit the button "View" which opens the page in FE having the ?no_cache=1 set in the URL - running om TYPO3 v. 9.5.3 the deprecation log gives me:

component="TYPO3.CMS.Frontend.Controller.TypoScriptFrontendController": $TSFE->set_no_cache() was triggered. Reason: &no_cache=1 has been supplied, so caching is disabled!

screen.PNG View (13.7 KB) Claus Harup, 2019-01-07 10:44

Associated revisions

Revision 3ea9c996 (diff)
Added by Georg Ringer about 1 month ago

[TASK] Remove no_cache=1 from preview url generation

The usage of no_cache should be avoided. If still required it can be added
by using the setting additionalGetParameters.

As the functionality goes into the PageRouter (effectively adds cHash),
and it's possible that "no_cache" is completely disabled, it is not
necessary to be set. This was not the case in v9 as Site Handling
was not available everywhere.

On top, if an editor is actually previewing the content on the page
(via EditDocumentController "save + view") DataHandler is actually
flushing the cache of the page/record associated
(e.g. cacheTags for records), which is much more recommended.

Resolves: #87347
Releases: master
Change-Id: I2bcedb4f92231329234684c9daae2843d08ec29d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59362
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Benjamin Franzke <>
Reviewed-by: Benni Mack <>
Reviewed-by: Benjamin Franzke <>

History

#1 Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59362

#2 Updated by Benni Mack 3 months ago

  • Target version changed from next-patchlevel to Candidate for patchlevel

#3 Updated by Gerrit Code Review about 1 month ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59362

#4 Updated by Georg Ringer about 1 month ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF