Task #87516

Install tool should use PSR-15 middlewares instead of priority based request handlers

Added by Benjamin Franzke 11 months ago. Updated 7 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Start date:
2019-01-22
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The frontend and backend request handlers already use PSR-15 middlewares and so should the install tool.

Associated revisions

Revision 770d7afb (diff)
Added by Benjamin Franzke 11 months ago

[TASK] Use PSR-15 middlewares in install tool

Remove the old concept of priority-based HTTP request handlers,
and use statically configured PSR-15 middlewares instead.
Tranform the priority based request handlers into a set of
chained middlewares.

In case none of the middlewares handles the request a
NotFoundRequestHandler returns a 404 response
(replacing the previous exception that was thrown in that case).
This scheme of using a 404 handler as "last" request handler is
not new, it is also used in zend expressive (a PSR-15 framework).

The TYPO3 RequestHandlerInterface is marked @internal and was set
to be removed in v9, therefore we drop it now and also remove its
implementation from the frontend and backend request handlers.

Releases: master
Resolves: #87516
Change-Id: Ibbd6a0e6c4ff8aa55b4367c9e4c07e279595dbfb
Reviewed-on: https://review.typo3.org/59541
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

History

#1 Updated by Gerrit Code Review 11 months ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59541

#2 Updated by Gerrit Code Review 11 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59541

#3 Updated by Gerrit Code Review 11 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59541

#4 Updated by Gerrit Code Review 11 months ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/59541

#5 Updated by Benjamin Franzke 11 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 7 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF