Bug #87530

Users adding a FAL video (oembed) must be warned if the video already existed in the folder ("FileList > New > Add new media asset" )

Added by Leonie Philine Bitto 10 months ago. Updated 6 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2019-01-23
Due date:
% Done:

0%

TYPO3 Version:
9
PHP Version:
7.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\AbstractOEmbedHelper::transformMediaIdToFile() starts with a call to $file = $this->findExistingFileByOnlineMediaId($mediaId, $targetFolder, $fileExtension).

When successful, \TYPO3\CMS\Backend\Controller\OnlineMediaController::addMediaFromUrl() does not inform if new media was actually added (= new XYZ.vimeo or XYZ.youtube file) or just existing media found in the folder.

Instead, \TYPO3\CMS\Backend\Controller\OnlineMediaController::mainAction() always renders a flash message saying 'LLL:EXT:lang/Resources/Private/Language/locallang_core.xlf:online_media.new_media.added', which is simply untrue and misleading if the video file was not newly added, but found to exist - possibly under an unexpected file name.

You can choose if the "add media" process is regarded as successful or failed in this case, but nonetheless the user must be warned that no new file was added to the file list.

Target:
Behavior is identical in TYPO3 8 and 9.

History

#1 Updated by Leonie Philine Bitto 10 months ago

  • Category set to File Abstraction Layer (FAL)

#2 Updated by Guido Schmechel 9 months ago

The info whether the file exists or not, is already decided in sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOEmbedHelper.php. This info will not be passed on. It would have to be well adjusted 3 to 4 classes, so that the info can be used.

For me, the question arises, whether this is crucial for you? Is there a problem that I did not notice? Beside the informational hint.

#3 Updated by Leonie Philine Bitto 6 months ago

It caused #87529 to remain mysterious until confusing debugging revealed its actual root cause.

Anyway, the current approach is miss-informing users.
An editor might want to know that they can save themselves the time to create lots of e.g. *.vimeo files, if they exist already. TYPO3 is lying to the editor, telling them they successfully created a file, while actually nothing was created. This is clearly a bug.

Also available in: Atom PDF