Bug #87548: LocalCropScaleMaskHelper uses incorrect stripProfileCommand - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #87548

closed

LocalCropScaleMaskHelper uses incorrect stripProfileCommand

Added by Robert Vock almost 6 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Image Generation / GIFBUILDER

Target version:

Start date:

2019-01-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The LocalCropScaleMaskHelper checks if the configuration variable processor_stripColorProfileCommand is not empty and then uses processor_stripProfileCommand (Note that Color is missing):
LocalCropScaleMaskHelper.php#L328

But I think that code part could be removed. Only the ###SkipStripProfile### is needed which will prevent the imageMagickCommand from adding the stripColorProfileCommand:
CommandUtility.php#L121

Actions

Copy link

Updated by Benni Mack over 5 years ago

Hey robert,

whow. what a classic mistake. Thanks for the findings!

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60465

Actions

Copy link

Updated by Gerrit Code Review over 5 years ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60469

Actions

Copy link