Task #87735

Do not use ObjectManager to instantiate PageTitleProviderManager

Added by Benjamin Franzke 4 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2019-02-18
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

PageTitleProviderManager is not marked as internal and public API of
EXT:core should not depend on initialization through the EXT:extbase
ObjectManager.

PageTitleProviderManager actually does not use any ObjectManager features,
so the current instantiation in TypoScriptFrontendController can simply be
replaced by GeneralUtility::makeInstance().

Associated revisions

Revision 52923931 (diff)
Added by Benjamin Franzke 4 months ago

[TASK] Do not use ObjectManager to instantiate PageTitleProviderManager

PageTitleProviderManager is public API in EXT:core and should therefore
not depend on initialization through the EXT:extbase ObjectManager.

PageTitleProviderManager actually does not use any ObjectManager features,
so the current instantiation in TypoScriptFrontendController can simply be
replaced by GeneralUtility::makeInstance().

Releases: master, 9.5
Resolves: #87735
Change-Id: I56231f834b6cf40d613bea84334eb48d03ca6094
Reviewed-on: https://review.typo3.org/c/59752
Tested-by: TYPO3com <>
Tested-by: Benni Mack <>
Tested-by: Markus Klein <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Benni Mack <>
Reviewed-by: Oliver Klee <>
Reviewed-by: Markus Klein <>

Revision a3f10929 (diff)
Added by Benjamin Franzke 4 months ago

[TASK] Do not use ObjectManager to instantiate PageTitleProviderManager

PageTitleProviderManager is public API in EXT:core and should therefore
not depend on initialization through the EXT:extbase ObjectManager.

PageTitleProviderManager actually does not use any ObjectManager features,
so the current instantiation in TypoScriptFrontendController can simply be
replaced by GeneralUtility::makeInstance().

Releases: master, 9.5
Resolves: #87735
Change-Id: I56231f834b6cf40d613bea84334eb48d03ca6094
Reviewed-on: https://review.typo3.org/c/59760
Tested-by: TYPO3com <>
Tested-by: Markus Klein
Reviewed-by: Oliver Klee <>
Reviewed-by: Markus Klein

History

#1 Updated by Gerrit Code Review 4 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59752

#2 Updated by Gerrit Code Review 4 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59752

#3 Updated by Gerrit Code Review 4 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59760

#4 Updated by Benjamin Franzke 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF