Task #87739

Epic #83968: PSR-11 Initiative

Mock ResourceFactory Singleton instantation in unit tests

Added by Benjamin Franzke 8 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2019-02-19
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

This prevents indirect SignalSlotDispatcher and ObjectManager
invocation by stubbing the ResourceFactory (or removing unneeded
mocks by preventing constructor invocation as in ImageServiceTest).

Associated revisions

Revision 191d0bdb (diff)
Added by Benjamin Franzke 8 months ago

[TASK] Mock ResourceFactory Singletons in unit tests

This prevents indirect SignalSlotDispatcher and ObjectManager
invocation by stubbing the ResourceFactory (or removing unneeded
mocks by preventing constructor invocation as in ImageServiceTest).

Releases: master, 9.5
Resolves: #87739
Change-Id: I70c5413fbdf66f3deb8ae0113e62f17ad8168f19
Reviewed-on: https://review.typo3.org/c/59754
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Anja Leichsenring <>

Revision 5fe3faaf (diff)
Added by Benjamin Franzke 8 months ago

[TASK] Mock ResourceFactory Singletons in unit tests

This prevents indirect SignalSlotDispatcher and ObjectManager
invocation by stubbing the ResourceFactory (or removing unneeded
mocks by preventing constructor invocation as in ImageServiceTest).

Releases: master, 9.5
Resolves: #87739
Change-Id: I70c5413fbdf66f3deb8ae0113e62f17ad8168f19
Reviewed-on: https://review.typo3.org/c/59786
Tested-by: TYPO3com <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Anja Leichsenring <>

History

#1 Updated by Gerrit Code Review 8 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59754

#2 Updated by Gerrit Code Review 8 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59754

#3 Updated by Gerrit Code Review 8 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59754

#4 Updated by Gerrit Code Review 8 months ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59786

#5 Updated by Benjamin Franzke 8 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack 5 months ago

  • Status changed from Resolved to Closed

#7 Updated by Benjamin Franzke 3 months ago

  • Parent task set to #83968

Also available in: Atom PDF